feat: Initialize missing submodules and fix POM errors#14
Merged
Conversation
- Added 5 missing submodules: * GuicedEE/consul-service-resolver * GuicedEE/runtime-autoconfigure * GuicedEE/service-discovery * GuicedEE/service-registry * GuicedEE/website-backend - Fixed POM configuration errors: * Removed non-existent GuicedEE/consul module reference * Corrected EntityAssist module path to EntityAssist/EntityAssist - Updated all existing submodules to latest commits - All 112 submodules now properly initialized and synchronized
There was a problem hiding this comment.
Pull request overview
This PR updates the root Maven aggregator configuration and related project metadata to align with the repository’s actual submodule layout, fixing module path errors that prevented successful Maven validation and ensuring submodules are tracked consistently.
Changes:
- Removed a non-existent Maven module entry (
GuicedEE/consul) from the rootpom.xml. - Updated the
entityassistMaven profile to reference the correct submodule path (EntityAssist/EntityAssist), matching.gitmodules. - Updated IntelliJ run configurations to include a
compilegoal beforejwebmp-angular:watch, and addedbranch = masterfor submodules that were missing it in.gitmodules.
Reviewed changes
Copilot reviewed 22 out of 24 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
pom.xml |
Fixes Maven module list/profile module path to match actual submodule layout and remove a non-existent module. |
.idea/runConfigurations/GuicedEE_Website.xml |
Adds compile goal before Angular watch goal for the GuicedEE website run config. |
.idea/runConfigurations/Entity_Assist_Website.xml |
Adds compile goal before Angular watch goal for the EntityAssist website run config. |
.gitmodules |
Adds branch = master entries for specific submodules to match existing .gitmodules conventions. |
Files not reviewed (2)
- .idea/runConfigurations/Entity_Assist_Website.xml: Language not supported
- .idea/runConfigurations/GuicedEE_Website.xml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses submodule initialization issues and fixes Maven POM errors in the development suite.
Changes
Added Missing Submodules (5)
These submodules were configured in
.gitmodulesbut were not added to the git index, causing them to not be initialized duringgit submodule update.Fixed POM Configuration Errors
GuicedEE/consul(directory doesn't exist)EntityAssisttoEntityAssist/EntityAssistto match actual project structureSubmodule Updates
Validation
Testing
Ran
mvn validateto confirm POM errors are resolved: